Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Client fixes, poll for unique last id and cache clients #434

Closed

Conversation

sakridge
Copy link
Contributor

So we don't keep running up the port range

@garious
Copy link
Contributor

garious commented Jun 24, 2018

Cool, but this makes it clear that we no longer have a client demo. It's a set of clients, working their hardest to beat up on fullnode. Can you document that somewhere? In the readme and/or the client-demo module documentation. We should consider renaming the module to make space for a far simpler client demo. multiclient-demo.rs?

@garious
Copy link
Contributor

garious commented Jun 24, 2018

Can you rebase on #435 after it goes in? It fixes 1 of 2 CI problems, and the 2nd is easy to spot/ignore.

@sakridge
Copy link
Contributor Author

That has been the case for a while that we use multiple threads. User can pass -t to just get one thread.

@sakridge
Copy link
Contributor Author

and yes, will rebase

@garious
Copy link
Contributor

garious commented Jun 24, 2018

Ready for rebase

So we don't keep running up the port range
@sakridge sakridge force-pushed the client_last_id_and_port branch from 688d1b0 to 7941e62 Compare June 25, 2018 02:46
@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #434 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   91.15%   90.99%   -0.17%     
==========================================
  Files          36       36              
  Lines        3583     3541      -42     
==========================================
- Hits         3266     3222      -44     
- Misses        317      319       +2
Impacted Files Coverage Δ
src/entry_writer.rs 82.85% <0%> (-5.72%) ⬇️
src/crdt.rs 86.01% <0%> (-0.81%) ⬇️
src/server.rs 94.5% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfcb79...7941e62. Read the comment docs.

@garious
Copy link
Contributor

garious commented Jun 25, 2018

@sakridge, rebase to run the latest CI, which is now quick and stable.

@garious
Copy link
Contributor

garious commented Jun 25, 2018

Merged in #440

@garious garious closed this Jun 25, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
…voke (solana-labs#434)

* Add failing test

* No need to hold source RefMut in process_approve

* Add revoke cases

* No need to hold source RefMut in process_revoke
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants